add common clang-format rules #459
Conversation
| @@ -74,6 +75,7 @@ | |||
| "devDependencies": { | |||
| "bower": "^1.7.9", | |||
| "chai": "^3.5.0", | |||
| "clang-format": "^1.0.45", | |||
There was a problem hiding this comment.
pin to a specific version please
|
I will rebase this off of master once the current batch of PRs are merged, and then commit the reformatting for a final look before merging. |
|
Will there ever be a time when there's not a batch of open PRs? |
|
If we can get #490 in we should be good. Trying to avoid unnecessary work for @justinfagnani if we can. No harm in seeing it here though, and then rebasing later. Pushing formatted code up to this branch... |
FredKSchott
force-pushed
the
clang-format
branch
from
8fdd881
to
d27836f
Compare
FredKSchott
force-pushed
the
clang-format
branch
from
43908fd
to
ff6fa8d
Compare
| @@ -21,6 +25,8 @@ const m = chalk.magenta; | |||
| const CLI_TITLE = chalk.bold.underline('Polymer-CLI'); | |||
| const CLI_DESCRIPTION = 'The multi-tool for Polymer projects'; | |||
| const CLI_USAGE = 'Usage: \`polymer <command> [options ...]\`'; | |||
|
|
|||
| // clang-format off - keep the custom white space here to help readibility | |||
There was a problem hiding this comment.
looks like this is working now! Woo!
|
|
||
| let buildStream = mergeStream(sourcesStream, depsStream) | ||
| .once('data', () => { logger.debug('Analyzing build dependencies...'); }) | ||
| .pipe(polymerProject.analyzer); | ||
| .once( |
There was a problem hiding this comment.
ugh, it's such a shame that these get so indented. No option to fix it as far as I could tell
|
@rictic PTAL |
| @@ -1,8 +1,9 @@ | |||
| import {minify as uglify, MinifyOptions as UglifyOptions} from 'uglify-js'; | |||
| import {css as cssSlam} from 'css-slam'; | |||
There was a problem hiding this comment.
Need to add the license header
| @@ -21,6 +25,8 @@ const m = chalk.magenta; | |||
| const CLI_TITLE = chalk.bold.underline('Polymer-CLI'); | |||
| const CLI_DESCRIPTION = 'The multi-tool for Polymer projects'; | |||
| const CLI_USAGE = 'Usage: \`polymer <command> [options ...]\`'; | |||
|
|
|||
| // clang-format off - keep the custom white space here to help readibility | |||
Only merge when there are no outstanding PRs, and remember to run
npm run formatafter merging!/cc @rictic @justinfagnani