Skip to content
This repository has been archived by the owner on Dec 7, 2021. It is now read-only.

polymer build --base-path <some string> to set the basePath option #830

Merged
merged 4 commits into from
Oct 31, 2017
Merged

polymer build --base-path <some string> to set the basePath option #830

merged 4 commits into from
Oct 31, 2017

Conversation

oskarlh
Copy link
Contributor

@oskarlh oskarlh commented Jul 28, 2017

This adds a --base-path CLI argument, which was missing.

  • CHANGELOG.md has been updated

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@oskarlh
Copy link
Contributor Author

oskarlh commented Jul 28, 2017

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@oskarlh
Copy link
Contributor Author

oskarlh commented Oct 21, 2017

I would be very grateful if someone could take a look at this 😄

@aomarks aomarks merged commit a4f5c98 into Polymer:master Oct 31, 2017
@aomarks
Copy link
Member

aomarks commented Oct 31, 2017

Thanks for the PR @oskarlh, merged!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants