Fix #827. Merge commandline options with named build configuration options #930
Conversation
src/build/build.ts
Outdated
| // If a config for the current buildName is present | ||
| // Merge the projects optimizeOptions with the options | ||
| // Commandline options will override the projects options | ||
| const projectOptions = polymerProject.config.builds.find(buildConfig => buildConfig.name === buildName); |
There was a problem hiding this comment.
You can destructure css, js and html directly. Then line 49 instead of projectOptimizeOptions you can do {css, js, html}
There was a problem hiding this comment.
But what if one of the options is not available, then the option where it should be merged to will be overridden with undefined
There was a problem hiding this comment.
Also, haven't seen any regression tests for the build/cli options. So that's why I didn't add one
|
Please take another look. I've changed it quite a bit. Should be better now
Can you tell me where to put the tests? Since it's quite a bit more complex than I thought at the start [edit:] I've squashed all commits into one. It should be good now. |
|
There are no tests for this at this moment. Please provide an infrastructure for it, or merge this MR because it fixes the |
|
Closing this pull request because this repo is now archived. If this PR is still active, please submit a new one at https://github.com/Polymer/tools. |
This fixes #827
When building from command line with
--name <buildName>, it now takes the options from the command line, merges them with the project's options and continues the build.It's probably fixing #613 as well.