This repository has been archived by the owner on Dec 7, 2021. It is now read-only.
Create .gitignore when execute init command
#957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FredKSchott
suggested changes
Feb 5, 2018
gulpfile.js
Outdated
| @@ -37,7 +37,8 @@ gulp.task('compile', () => { | |||
| let tsReporter = typescript.reporter.defaultReporter(); | |||
| return mergeStream( | |||
| tsProject.src().pipe(tsProject(tsReporter)), | |||
| gulp.src(['src/**/*', '!src/**/*.ts'])) | |||
| gulp.src(['src/**/*', '!src/**/*.ts']), | |||
| gulp.src(['src/**/.gitignore'])) | |||
There was a problem hiding this comment.
This like should be unnecessary, no need to compile .gitignore with typescript
|
@FredKSchott Thanks for your reviews ! |
|
Did yeoman make it to where it doesn't ignore hidden files? I remember looking at this a while back and thought it would ignore hidden files. @sottar have you checked this? |
|
@stramel |
|
@FredKSchott I restarted the tests and they pass... lgty? |
|
Fixes #531 as well |
justinfagnani
approved these changes
Mar 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #953
Summary
Automatically generate a
.gitignorefile when execute init command and selectelementorapplication.