Skip to content
This repository has been archived by the owner on Dec 7, 2021. It is now read-only.

New: Run custom builds from associated commands #967

Closed
wants to merge 2 commits into from

Conversation

stramel
Copy link
Contributor

@stramel stramel commented Mar 8, 2018

  • CHANGELOG.md has been updated

Wanted to get an okay before getting too far. What I have currently functions as expected.

@FredKSchott had brought up a while ago that it would be nice for someone to add an NPM script and be able to run that from the associated Polymer CLI command. For example,

package.json

{
  "scripts": {
    "polymer:build": "gulp build"
  }
}

Then running polymer build in the console would result in the custom gulp build command being run instead of the default build process. If that NPM script is not present, it will run the default process.

I have set it up to where all commands except help follow the syntax polymer:<command>.

@justinfagnani justinfagnani self-requested a review March 8, 2018 22:01
@kito99
Copy link

kito99 commented Mar 9, 2018

I'd like to see the ability to bypass this if necessary. For example, I'd like for polymer build to be equivalent to this: tsc && polymer build. As-is, this would cause an infinite loop, so we'd need support for something like this: tsc && polymer build -bypass-custom-commands.

@stramel
Copy link
Contributor Author

stramel commented Mar 9, 2018

@kito99 Ah, I see what you mean. I think we could easily add a --bypass-custom-command, --ignore-custom-command, or whatever naming the Polymer team would want for a flag to bypass.

@stramel
Copy link
Contributor Author

stramel commented Apr 8, 2018

Ping @justinfagnani I can't remember what you wanted done here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants