Skip to content
This repository has been archived by the owner on Dec 7, 2021. It is now read-only.

Fix missing gulp-if dependency. #986

Merged
merged 2 commits into from
Apr 4, 2018
Merged

Fix missing gulp-if dependency. #986

merged 2 commits into from
Apr 4, 2018

Conversation

aomarks
Copy link
Member

@aomarks aomarks commented Apr 4, 2018

  • CHANGELOG.md has been updated

@aomarks aomarks requested a review from rictic April 4, 2018 02:40
rictic
rictic reviewed Apr 4, 2018
View reviewed changes
Copy link
Contributor

@rictic rictic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update the shrinkwrap?

@aomarks
Copy link
Member Author

aomarks commented Apr 4, 2018 •
edited
Loading

Do we need to update the shrinkwrap?

I assumed that running npm install --save newdep would update it if it needed to. Not the case?

@aomarks
Copy link
Member Author

aomarks commented Apr 4, 2018

Do we need to update the shrinkwrap?

I assumed that running npm install --save newdep would update it if it needed to. Not the case?

I ran npm install afterwards, and it updated the shrinkwrap. That seems like a bug.

@aomarks
Copy link
Member Author

aomarks commented Apr 4, 2018

PTAL.

@aomarks aomarks merged commit fbd88cc into master Apr 4, 2018
@aomarks aomarks deleted the gulp-if branch April 4, 2018 18:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rictic rictic rictic approved these changes

@justinfagnani justinfagnani Awaiting requested review from justinfagnani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aomarks @rictic