Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

Add style guide/beautifier #933

Closed
robdodson opened this issue Oct 16, 2016 · 8 comments
Closed

Add style guide/beautifier #933

robdodson opened this issue Oct 16, 2016 · 8 comments
Labels
styling

Comments

@robdodson
Copy link
Contributor

Need to add a link to a style guide and some eslint rules so PRs can have a consistent look and feel
@robdodson robdodson mentioned this issue Oct 16, 2016
Merged
@abdonrd
Copy link
Contributor

abdonrd commented Oct 16, 2016

Yes, please!

@robdodson
Copy link
Contributor Author

@abdonrd I don't have a strong opinion here, do you want to take this on?

@abdonrd
Copy link
Contributor

abdonrd commented Nov 20, 2016

Ok! I think we should use ESLint to lint Javascript.
And maybe StyleLint for CSS.

@robdodson
Copy link
Contributor Author

ok. i'm doing this today. it's happening. for reals.

@robdodson
Copy link
Contributor Author

We may have to hold off on Stylelint. It doesn't seem to process the line numbers correctly. Added a +1 to this issue ccbikai/stylelint-processor-html#1

@abdonrd
Copy link
Contributor

abdonrd commented Dec 13, 2016

Ok, thanks @robdodson!

@abdonrd
Copy link
Contributor

abdonrd commented Feb 15, 2017

@robdodson could you integrate it with VSCode? I can't: https://github.com/shinnn/vscode-stylelint/issues/52

@TimvdLippe
Copy link
Contributor

ESLint was introduced in #951 but this issue was not closed. @robdodson I think we can close it now or do you explicitly want to mention eslint in the README?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
styling
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@abdonrd @robdodson @TimvdLippe