Fix _patchMatchesEffect. (#3631)

Listening for `foo.bar.*` does not trigger for `foo.bars`.
Polymer · Jun 20, 2016 · b78e5af · b78e5af
1 parent 1058896
commit b78e5af
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 1 deletion.
diff --git a/src/standard/notify-path.html b/src/standard/notify-path.html
@@ -324,7 +324,7 @@
         var effectArg = effect.trigger.name;
         return (effectArg == path) ||
           (effectArg.indexOf(path + '.') === 0) ||
-          (effect.trigger.wildcard && path.indexOf(effectArg) === 0);
+          (effect.trigger.wildcard && path.indexOf(effectArg + '.') === 0);
       },
 
       /**

diff --git a/test/unit/notify-path.html b/test/unit/notify-path.html
@@ -950,6 +950,38 @@
     arraysEqual(el.array, [-1, 99, 2, 3]);
   });
 
+  test('patch matches effect', function() {
+    var effect = {
+      trigger: {
+        name: 'foo.bar'
+      }
+    };
+
+    assert.isTrue(el._pathMatchesEffect('foo', effect));
+    assert.isTrue(el._pathMatchesEffect('foo.bar', effect));
+
+    assert.notOk(el._pathMatchesEffect('bar', effect));
+    assert.notOk(el._pathMatchesEffect('foobar', effect));
+    assert.notOk(el._pathMatchesEffect('foo.bar.baz', effect));
+    assert.notOk(el._pathMatchesEffect('foo.baz', effect));
+
+    effect = {
+      trigger: {
+        name: 'foo.bar',
+        wildcard: true
+      }
+    };
+
+    assert.isTrue(el._pathMatchesEffect('foo', effect));
+    assert.isTrue(el._pathMatchesEffect('foo.bar', effect));
+    assert.isTrue(el._pathMatchesEffect('foo.bar.baz', effect));
+
+    assert.notOk(el._pathMatchesEffect('foobar', effect));
+    assert.notOk(el._pathMatchesEffect('foo.bars', effect));
+    assert.notOk(el._pathMatchesEffect('foo.baz', effect));
+
+  });
+
 });
 
 suite('malformed observers', function() {