Merge pull request #2673 from JeremybellEU/input-value-annotated

Fix using value$ on input element
Polymer · Nov 18, 2015 · cfa6d51 · cfa6d51
2 parents 0345137 + 05a1e95
commit cfa6d51
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 17 deletions.
diff --git a/src/lib/annotations/annotations.html b/src/lib/annotations/annotations.html
@@ -330,7 +330,7 @@
         // `value` attribute if it previously had a value (can't
         // unconditionally set '' before removing since attributes with `$`
         // can't be set using setAttribute)
-        if (node.localName == 'input' && name == 'value') {
+        if (node.localName === 'input' && origName === 'value') {
           node.setAttribute(origName, '');
         }
         // Remove annotation

diff --git a/test/unit/bind-elements.html b/test/unit/bind-elements.html
@@ -435,20 +435,26 @@
 </script>
 
 <dom-module id="x-entity-and-binding">
-    <template>
-      <p>&copy;</p>
-      <p id="binding">{{myText}}</p>
-    </template>
-  </dom-module>
+  <template>
+    <p>&copy;</p>
+    <p id="binding">{{myText}}</p>
+  </template>
+</dom-module>
 
-  <script>
-    Polymer({
-      is: "x-entity-and-binding",
-      properties: {
-        myText: {
-          type: String,
-          value: 'binding'
-        }
+<script>
+  Polymer({
+    is: "x-entity-and-binding",
+    properties: {
+      myText: {
+        type: String,
+        value: 'binding'
       }
-    });
-  </script>
+    }
+  });
+</script>
+
+<dom-module id="x-input-value">
+  <template>
+    <input id="input" value$="{{inputValue}}">
+  </template>
+</dom-module>
diff --git a/test/unit/bind.html b/test/unit/bind.html
@@ -16,7 +16,6 @@
   <link rel="import" href="../../polymer.html">
   <link rel="import" href="bind-elements.html">
 <body>
-
 <script>
 
 suite('single-element binding effects', function() {
@@ -595,6 +594,17 @@
     assert(!el.$.boundChild.hasAttribute('attrvalue'));
   });
 
+  test('bind to value attribute on input should not fail', function() {
+    Polymer({
+      is: 'x-input-value'
+    });
+
+    var el = document.createElement('x-input-value');
+    el.inputValue = "the value";
+    assert.equal(el.$.input.value, "the value", "The value of the input is not propagated");
+    assert.equal(el.$.input.value$, undefined, "value$ should be removed from input");
+  });
+
 });
 
 suite('avoid non-bubbling event gotchas', function() {