Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove preventDefault from track #1824

Closed
dfreedm opened this issue Jun 10, 2015 · 0 comments
Closed

Remove preventDefault from track #1824

dfreedm opened this issue Jun 10, 2015 · 0 comments
Assignees
@dfreedm
Labels
p1

Comments

@dfreedm
Copy link
Member

dfreedm commented Jun 10, 2015

Currently the track event will preventDefault the mouse events to stop selection. However, there is no way for the user to control this behavior.

Instead, we should provide API on the down or track event to enable this behavior.
This would be a minor breaking change, requiring devs to use user-select: none or preventDefault on down or track event.

@frankiefu @blasten
@dfreedm dfreedm added the p1 label Jun 10, 2015
@dfreedm dfreedm self-assigned this Jun 10, 2015
dfreedm added a commit that referenced this issue Jun 12, 2015
@dfreedm
Allow user prevention of tap and track gestures from down
11869f2 
New API: `event.detail.prevent('tap')` and `event.detail.prevent('track')`
Fixes #1823

Forward `preventDefault` from gesture events to source events

`gesture.preventDefault()` is equivalent to
`gesture.detail.sourceEvent.preventDefault()`

Remove `preventDefault()` on mousemove in track, user must use
`track.preventDefault()` to hide user selection or use `user-select:none`
Fixes #1824
@dfreedm dfreedm mentioned this issue Jun 12, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dfreedm dfreedm

Labels
p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dfreedm