-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async main page import changes upgrade order of subimport deps #2522
Comments
This might be similar to what happens in #2481. Some of the elements assume to be in a synchronous world and they really shouldn't. IMO, we need a lot more work here. I'm also experiencing this with updating Polymer's TodoMVC app. There definitely seems to be timing issues when you make the main page import
That seems to always work for me. |
@ebidel How can I use vulcanize to bundle a set of elements for importing into another element without Polymer being included multiple times or not at all? Every time I've taken a swing at vulcanizing elements, I've encountered breakage. |
You can use vulcanize's |
@ebidel Using the following, vulcanize goes through just fine. However, the resulting import gives the following errors.
|
@ebidel trying to use your strategy (dev non async, vulcanized async) on the Polymer Starter Kit, but no luck. Looks like some of the styles are not being applied. Any news on this? |
I'm not sure what you mean by making the dependencies synchronous. |
@azakus This question was me grasping at straws to try to understand why async'ing imports was breaking things. Specifically, I'm having the issue described below but the issue was erroneously closed and we can't get anyone from the Polymer team to reopen / answer. |
@azakus, if you add Repo From #2678 (comment). Check out that repo and run the app. I used his vulcanized elements.html. Toggling Using
Using
This causes bindings to misbehavior b/c
|
#2653 would help the binding case |
Any updates on this? |
+1 |
It seems that this problem still exists in 1.7.1 and impacts also async importHref. When I import elements with importHref with async=true I get all kind of wired errors (like So are there any plans to address that issue in 1.x ? |
For me it seems that there are race conditions regarding the HTML Import map if you have multiple asynchronous HTML Import workers processing the same file/import. See StackOverflow for more information. |
Hi, any update regarding this? I'm also experiencing |
any update? i had similar problems and i lost DAYS to understand that "async" was the problem! |
Same here ( |
Sadly this appears to be an upstream bug at https://bugs.chromium.org/p/chromium/issues/detail?id=669710 I am not sure what the Polymer team can do, other than poking that issue. Eventually, async loading is changed to dynamic import with Polymer 3. |
Closing this issue per above comment. Native async HTML imports have an upstream bug in Chromium linked above that results in sub-dependencies loading being out of order. Since we are moving to ES modules with Polymer 3 and adopt dynamic import, this issue will be gone. Any potential fixes to async HTML import have to be published to Chromium, thus we have no further action available here. |
I've written an app shell element that provides little other than the structure to my app. All the functionality is brought in as separate elements in the light DOM. I'm async-ing those imports. This works fine for all but one. That one provides several
paper-dialog
s to the app. It appears that async-ing a top-level import also asyncs any dependency imports. This causes thepaper-dialog
to not render correctly (e.g. transparent background / nopaper-material
effects, etc.). Changing the top-level import to sync fixes the issue, but there's probably a first render performance hit. Is there any way to async an import but force its dependencies to be synchronously loaded?The text was updated successfully, but these errors were encountered: