Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text node children with bindings cause dom-if templates to update incorrectly. #3157

Closed
bicknellr opened this issue Dec 4, 2015 · 1 comment
Closed

Text node children with bindings cause dom-if templates to update incorrectly. #3157

bicknellr opened this issue Dec 4, 2015 · 1 comment
Assignees
@kevinpschaaf
Labels
bug databinding p0

Comments

@bicknellr
Copy link
Member

(Relaying a bug @kevinpschaaf reduced offline.) If a text node containing bindings is a child of a dom-if template, text updates don't always work as expected.

JSBin

  1. Type into field.
  2. Check the checkbox; the text shown is correct.
  3. Uncheck the checkbox.
  4. Type into field.
  5. Text incorrectly appears in dom-if even though the checkbox is not checked. (Text would be correct if visible.)
  6. Click checkbox to show text; text is shown with previous value (as entered in step 1).

(The binding within the span works as expected throughout.)
@kevinpschaaf kevinpschaaf self-assigned this Dec 4, 2015
@kevinpschaaf
Copy link
Member

Will be fixed by PR #3161.

JSBin repro using PR branch: http://jsbin.com/moguna/edit?html,output

sorvell pushed a commit that referenced this issue Dec 7, 2015
Merge pull request #3161 from Polymer/3157-kschaaf-domif-textnode
2c6161c 
Custom setProperty for bindings to hidden textNodes. Fixes #3157.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinpschaaf kevinpschaaf

Labels
bug databinding p0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bicknellr @kevinpschaaf