Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ready and created are listed in the wrong order #338

Closed
jyasskin opened this issue Nov 3, 2013 · 3 comments
Closed

ready and created are listed in the wrong order #338

jyasskin opened this issue Nov 3, 2013 · 3 comments

Comments

@jyasskin
Copy link

jyasskin commented Nov 3, 2013

At http://www.polymer-project.org/polymer.html#lifecyclemethods, the ready method is listed before created, but in fact created seems to be called before ready.

@dfreedm
Copy link
Member

dfreedm commented Nov 4, 2013

You are correct, ready fires after created. I'm not sure that the list was meant to be listed in order of calls, but it's certainly in a weird order right now.

@ebidel

@ebidel
Copy link
Contributor

ebidel commented Nov 5, 2013

Yea, the table is not meant to be an ordering. My reasoning for the current ordering is that ready is not one of the Custom Element callbacks. It's a Polymer-specific and I didn't want to it to get lost in the list. Maybe that's not important?

@sjmiles
Copy link
Contributor

sjmiles commented Nov 5, 2013

IMO, it's easy to assume the ordering in the table corresponds to the
callback timing order.

On Mon, Nov 4, 2013 at 4:50 PM, Eric Bidelman notifications@github.comwrote:

Yea, the table is not meant to be an ordering. My reasoning for the
current ordering is that ready is not one of the Custom Element
callbacks. It's a Polymer-specific and I didn't want to it to get lost in
the list. Maybe that's not important?


Reply to this email directly or view it on GitHubhttps://github.com//issues/338#issuecomment-27738098
.

ebidel added a commit to Polymer/old-docs-site that referenced this issue Nov 5, 2013
@ebidel ebidel closed this as completed Nov 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants