You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Depending on the order you define custom elements, ShadyCSS mixins do not apply
Live Demos
These two demos show the importance of element load order with shadycss mixins. They both have markup using custom elements, then define the elements, then the same markup is repeated.
The discrepancy occurs when markup is placed before custom element definition.
Both examples show the mixins are applied correctly when the markup is placed after custom element definition.
It is my belief that ShadyCSS mixins should be applied regardless of markup position and definition order. If for example the import of the element defining the mixin is delayed for some reason, this becomes a real world problem.
Versions
Polymer: 2.0-preview
webcomponents: v1
The text was updated successfully, but these errors were encountered:
@azakus as the assignee I wondered if you were available at some point to discuss this issue.
I've done some investigation into resolving this in https://github.com/webcomponents/shadycss and found a couple of points, but wanted to know your thoughts on performance implications. Would it be easier to write an associated issue on shadycss and issue some PRs, or could I reach out to you on polymer slack?
Apologies if this should be posted in https://github.com/webcomponents/shadycss.
Description
Depending on the order you define custom elements, ShadyCSS mixins do not apply
Live Demos
These two demos show the importance of element load order with shadycss mixins. They both have markup using custom elements, then define the elements, then the same markup is repeated.
The discrepancy occurs when markup is placed before custom element definition.
Both examples show the mixins are applied correctly when the markup is placed after custom element definition.
Broken: http://codepen.io/oridan/pen/LRKqKV?editors=1000
The broken demo shows the mixin HAS NOT been applied where the x-item element is defined BEFORE the x-group element.
Working: http://codepen.io/oridan/pen/yadrmX?editors=1000
The working demo shows the mixin HAS been applied where the x-item element is defined AFTER the x-group element.
Expected Behavior
It is my belief that ShadyCSS mixins should be applied regardless of markup position and definition order. If for example the import of the element defining the mixin is delayed for some reason, this becomes a real world problem.
Versions
The text was updated successfully, but these errors were encountered: