Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ShadyCSS] Mixins applied inconsistently #35

Open
TomK opened this issue Nov 1, 2016 · 3 comments
Open

[ShadyCSS] Mixins applied inconsistently #35

TomK opened this issue Nov 1, 2016 · 3 comments

Comments

@TomK
Copy link

TomK commented Nov 1, 2016

REF Polymer/polymer#4115
Distributed nodes appear to be styled with mixins defined in the host, providing they are applied after the host has been defined.

Please note the following demo: http://codepen.io/oridan/pen/edqMPO?editors=1000
Item B simply extends Item A with no other changes. Therefore they should both display exactly the same. The expected result as I understand it should be per as the following image:
image

RFC:
I have resolved this where nativeCssVariables == true by applying the following two diffs:
webcomponents/shadycss@master...TomK:apply-host-descendants - quite inefficient
webcomponents/shadycss@master...TomK:refresh-invalid-shim

I understand this is not a complete resolution, and possibly this implementation is not feasible. So I am hoping for comments/suggestions to steer towards a viable solution.

@dfreedm
Copy link
Contributor

dfreedm commented Nov 10, 2016

Thanks for the test case. I think I have a simpler method that moves the invalid flag onto the element instances.
Then sometime later, you can trigger an applyStyle on all of them.

@dfreedm dfreedm self-assigned this Nov 10, 2016
dfreedm referenced this issue in webcomponents/shadycss Nov 16, 2016
dfreedm referenced this issue in webcomponents/shadycss Nov 17, 2016
dfreedm referenced this issue in webcomponents/shadycss Dec 5, 2016
@TomK
Copy link
Author

TomK commented May 31, 2017

@azakus any updates on this issue please?

@dfreedm dfreedm transferred this issue from webcomponents/shadycss Jun 7, 2019
dfreedm pushed a commit that referenced this issue Jun 11, 2019
keep track of the created wrappedFn
@dfreedm dfreedm changed the title Mixins applied inconsistently [ShadyCSS] Mixins applied inconsistently Jun 12, 2019
@dfreedm dfreedm added Severity: Medium Type: Feature New feature or request labels Jun 13, 2019
@stale
Copy link

stale bot commented Apr 22, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants