Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing cancelBubble #74

Closed
arv opened this issue Feb 12, 2013 · 5 comments
Closed

Confusing cancelBubble #74

arv opened this issue Feb 12, 2013 · 5 comments
Assignees

Comments

@arv
Copy link
Contributor

arv commented Feb 12, 2013

The code seems to have some strange behavior related to cancelBubble in the event handlers.

For example if I have two functions listening to the same event on the same target and the first one calls event.stopPropagation() the second one should still be called.

I don't understand what the intent is by checking cancelBubble. Did you mean to check defaultPrevented?

@dfreedm
Copy link
Member

dfreedm commented Aug 12, 2013

This issue is super old, not sure if relevant anymore.

@dfreedm dfreedm closed this as completed Aug 12, 2013
@sjmiles sjmiles reopened this Aug 12, 2013
@sjmiles
Copy link
Contributor

sjmiles commented Aug 12, 2013

We haven't actually answered this satisfactorily. It also helps me remember that we have a general issue that our event delegation system is under-designed.

@addyosmani
Copy link
Member

Is this still relevant given that cancelBubble has been deprecated? http://dom.spec.whatwg.org/#event

@sorvell
Copy link
Contributor

sorvell commented Mar 17, 2014

cancelBubble is no longer relevant. Polymer no longer does event
dispatching, instead putting listeners directly on elements containing
declarative event attributes. The normal methods of affecting event
bubbling should now work: event.preventDefault() and
event.stopPropagation().

On Sun, Mar 16, 2014 at 2:08 PM, Addy Osmani notifications@github.comwrote:

Is this still relevant given that cancelBubble has been deprecated?
http://dom.spec.whatwg.org/#event


Reply to this email directly or view it on GitHubhttps://github.com//issues/74#issuecomment-37770994
.

@arv
Copy link
Contributor Author

arv commented Mar 18, 2014

Just to be clear preventDefault is unrelated to event propagation (a lot of
people have cargo culted these two into the same bucket)
On Mar 17, 2014 11:25 AM, "Steve Orvell" notifications@github.com wrote:

cancelBubble is no longer relevant. Polymer no longer does event
dispatching, instead putting listeners directly on elements containing
declarative event attributes. The normal methods of affecting event
bubbling should now work: event.preventDefault() and
event.stopPropagation().

On Sun, Mar 16, 2014 at 2:08 PM, Addy Osmani notifications@github.comwrote:

Is this still relevant given that cancelBubble has been deprecated?
http://dom.spec.whatwg.org/#event


Reply to this email directly or view it on GitHub<
https://github.com/Polymer/polymer/issues/74#issuecomment-37770994>
.


Reply to this email directly or view it on GitHubhttps://github.com//issues/74#issuecomment-37828402
.

@sjmiles sjmiles closed this as completed Aug 18, 2014
dfreedm pushed a commit that referenced this issue Sep 9, 2016
…enable to subclassing and may need to be rethought. To work around this issue for now, classes generated from Polymer 1 style objects use a separate mechanism to call `registered`.
dfreedm pushed a commit that referenced this issue Sep 9, 2016
Fixes #74. The `finalize` technique used in Polymer.Element is not am…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants