Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jsdoc for splice #1820

Merged
merged 1 commit into from Jun 10, 2015
Merged

Fix jsdoc for splice #1820

merged 1 commit into from Jun 10, 2015

Conversation

jscissr
Copy link
Contributor

@jscissr jscissr commented Jun 10, 2015

Array.prototype.splice returns an Array, not a Number. You could also change the code to do what the docs say instead.

@jscissr
Fix jsdoc for splice
ea98108 
Array.prototype.splice returns an Array, not a Number.
kevinpschaaf added a commit that referenced this pull request Jun 10, 2015
@kevinpschaaf
Merge pull request #1820 from jscissr/splice
6b43314 
Fix jsdoc for splice
@kevinpschaaf kevinpschaaf merged commit 6b43314 into Polymer:master Jun 10, 2015
@kevinpschaaf
Copy link
Member

Thanks! Yes, the intention is to match the native semantics.

@jscissr jscissr deleted the splice branch June 13, 2015 20:09
@jscissr jscissr mentioned this pull request Jun 13, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jscissr @kevinpschaaf @googlebot