Fix for custom styles parsing. #2692
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazar-pc
added a commit
to nazar-pc/CleverStyle-Framework
that referenced
this pull request
Nov 6, 2015
List of patches applied on top of git version (2 previous patches upstreamed, the rest are still here + 2 new patches added): * Polymer/polymer#2205 * Polymer/polymer#2247 * Polymer/polymer#2295 * Polymer/polymer#2349 * Polymer/polymer#2419 * Polymer/polymer#2642 * Polymer/polymer#2689 * Polymer/polymer#2692 * Polymer/polymer#2694
nazar-pc
force-pushed
the
fix-for-custom-style-parsing
branch
2 times, most recently
from
7dc46ab
to
77bde21
Compare
When custom style is second element in HTML import after script with `Polymer()` call.
nazar-pc
force-pushed
the
fix-for-custom-style-parsing
branch
from
77bde21
to
d89950a
Compare
nazar-pc
added a commit
to nazar-pc/CleverStyle-Framework
that referenced
this pull request
Nov 7, 2015
Now vulcanized imports are finally usable, yay!
|
Thanks for doing so much work on this. The fix looks simple but I'd like to understand the nature of the breakage before merging. Do you know if the issue is isolated to using the Shadow DOM polyfill? |
|
No, it happens with WebComponents lite and Shady DOM as well (in fact I've debugged it in such configuration to simplify stacktrace). It is actually because of how HTML Imports polyfill works. I guess HTML Imports polyfill will require to parse imports into set of root elements and insert them one by one in proper order manually instead of all together in order to mimic native behavior entirely, but it seems to overcomplicate polyfill's code base a lot and doesn't worth it. |
sorvell
pushed a commit
that referenced
this pull request
Nov 12, 2015
…ut before next render so that all properties are defined before any are consumed by custom-styles. Also refines dom-module's early upgrade code so that it does not affect other elements (corrects for example, custom-styles upgrading before expected).
nazar-pc
added a commit
to nazar-pc/CleverStyle-Framework
that referenced
this pull request
Nov 13, 2015
List of patches applied on top of git version (no new patches upstreamed since last time:(): * Polymer/polymer#2205 * Polymer/polymer#2247 * Polymer/polymer#2295 * Polymer/polymer#2349 * Polymer/polymer#2419 * Polymer/polymer#2642 * Polymer/polymer#2689 * https://github.com/Polymer/polymer/tree/fix-2692 branch supersedes Polymer/polymer#2692 * Polymer/polymer#2694
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When custom style is second element in HTML import after script with
Polymer()call.Fixes #2381