minor updates/fixes to g-component, selector and menu #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadow dom; provide a method to get selected item.
ghost
assigned 
| @@ -432,7 +432,7 @@ | |||
| // is in inNodes, if any | |||
| var n = inTarget; | |||
| while (n && n != this) { | |||
| var i = inNodes.indexOf(n); | |||
| var i = Array.prototype.indexOf.call(inNodes, n); | |||
There was a problem hiding this comment.
Can you be more specific about your use case where inNodes is a NodeList. When I wrote this method, I assumed the input would always be the result of getDistributedNodes(). Does that method return a NodeList under native ShadowDOM?
There was a problem hiding this comment.
Yes, getDistributedNodes() under native ShadowDOM returns a NodeList.
There was a problem hiding this comment.
Ok, not sure how I missed that. Thank you.
|
LGTM |
sjmiles
added a commit
that referenced
this pull request
Nov 5, 2012
minor updates/fixes to g-component, selector and menu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.