Refactor importHref #4209
Refactor importHref #4209
Conversation
Seems to be a typo, that break markdown formatting.
Remove dependency on CustomElements for IE detection
src/standard/utils.html
Outdated
| link = document.createElement('link'); | ||
| link.rel = 'import'; | ||
| link.href = href; | ||
| link.__loaded = false; |
There was a problem hiding this comment.
I think __loaded is already used by the polyfill, isn't it?
src/standard/utils.html
Outdated
| // In case of an error, remove the link from the document so that it | ||
| // will be automatically created again the next time `importHref` is | ||
| // called. | ||
| document.head.removeChild(link); | ||
| link.__loaded = true; | ||
| link.__error = true; |
There was a problem hiding this comment.
The intention of the change is to discard this link. What is the benefit of tracking state on the link if it is about to be discarded?
addressing feedback from @cdata Polymer#4209
addressed feedback from @cdata Polymer#4209 (review)
| throw new Error('Load handler should not be called.'); | ||
| }, function() { | ||
| b = Polymer.Base.importHref('does_not_exist.html', function() { | ||
| throw new Error('Load handler should still not be called.'); |
There was a problem hiding this comment.
Unless webcomponents/webcomponentsjs#655 is merged this test fill fail on browsers without native html imports support (e.g. Firefox on Travis CI).
Close backtick in ISSUE_TEMPLATE.md
…olymer#4262. * `Polymer.Settings.suppressTemplateNotifications `- disables `dom-change` and `rendered-item-count` events from `dom-if`, `dom-repeat`, and `don-bind`. Users can opt back into `dom-change` events by setting the `notify-dom-change` attribute (`notifyDomChange: true` property) to `dom-if`/`don-repeat` instances. * `Polymer.Settings.suppressBindingNotifications` - disables notify effects when propagating data downward via bindings. Generally these are never useful unless users are explicitly doing something like `<my-el foo="{{foo}} on-foo-changed="{{handleFoo}}">` or calling `addEventListener('foo-changed', ...)` on an element where `foo` is bound (we attempted to make this the default some time back but needed to revert it when we found via Polymer#3077 that users were indeed doing this). Users that avoid these patterns can enjoy the potentially significant benefit of suppressing unnecessary events during downward data flow by opting into this flag.
Fix `strip-whitespace` for nested templates.
…ents Add global flags to suppress unnecessary notification events. Fixes Polymer#4262
… unroll behavior lifecycle calls, (3) avoid creating a custom constructor when not used, (4) provide `_skipDefineProperty` setting on behaviors which copies properties via assignment rather than `copyOwnProperty`
1.x micro opts
Can't rely on `__proto__` on IE10, but that browser doesn't need to avoid `properties`.
… dom targeted css build and native custom properties, will copy styles into the Shadow DOM template rather than collapsing them into a single style. This will (1) allow the browser to optimize parsing of shared styles because they remain intact, (2) reduce the size of the css build resources when shared styles are used since they are not pre-collapsed. This option does perform registration runtime work to add included styles to element templates.
Read properties off of proto during configuration.
1.x style include
Exclude SD polyfill tests for Edge due to lack of workarounds for Edg…
change lastresponse to last-response in dom-bind example
Previously, importHref would cache failed results. This caused failures to be cached indefinitely, even when the failure was the result of conditions that are subject to change over time (such as poor network connectivity). This implementation no longer caches failures. Additionally, it relies on the link tag's presence in the <head> of the document as an indication that it is loading or has loaded, rather than keeping an object map of URLs to link tags.
addressing feedback from @cdata Polymer#4209
addressed feedback from @cdata Polymer#4209 (review)
gronke
force-pushed
the
enhance-refactor-import-href
branch
from
636c858
to
163f4c0
Compare
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
Since the base branch https://github.com/Polymer/polymer/tree/refactor-import-href was not rebased for a while, the new PR #4348 is pointing against master directly. Closing. |
Blocked by webcomponents/webcomponentsjs#655 because the load event is invoked twice when a failed import attempt is repeated.