App-level support for passive gesture touch listeners #4829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Hmm, looks like closure linting is broken on travis now :( |
TimvdLippe
approved these changes
Sep 7, 2017
Set Polymer.passiveTouchGestures to true to enable
dfreedm
force-pushed
the
optional-passive-gestures
branch
from
633fa25
to
6312da5
Compare
sorvell
suggested changes
Sep 7, 2017
lib/utils/settings.html
Outdated
| * | ||
| * @memberof Polymer | ||
| */ | ||
| Polymer.passiveTouchGestures = Polymer.passiveTouchGestures || false; |
There was a problem hiding this comment.
Should be a function for forward compatibility
lib/utils/gestures.html
Outdated
| window.addEventListener('test', null, opts); | ||
| window.removeEventListener('test', null, opts); | ||
| } catch(e) {} | ||
| })(); | ||
|
|
||
| // decide whether to use {passive: true} for gestures listening for touch events | ||
| let PASSIVE_TOUCH = Boolean(HAS_NATIVE_TA && SUPPORTS_PASSIVE && Polymer.passiveTouchGestures); |
There was a problem hiding this comment.
passiveTouchGestures should be a function for forward compat.
Clean up event listener options inside gestures that use passive touch
sorvell
approved these changes
Sep 11, 2017
|
This will ship as Polymer 2.1 |
dfreedm
added a commit
that referenced
this pull request
Sep 11, 2017
dfreedm
added a commit
that referenced
this pull request
Sep 12, 2017
Backport passive touch gestures #4829
|
This is labelled as being related to touch gestures, but will this also allow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apps can set
Polymer.passiveTouchGesturestotrueto force all touch listeners for gestures to use passive event handlers.This may improve scrolling performance, at the cost of being unable to control scrolling with
gestureEvent.preventDefault().Instead, elements must use
Polymer.Gestures.setTouchAction(node, 'direction')This PR overrules #4724
Fixes #4667
Fixes #3787
Fixes #3604