Update TemplateStamp event listen param types from Node to EventTarget. #5320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows passing e.g. window.
aomarks
requested review from
kevinpschaaf,
sorvell and
TimvdLippe
as code owners
TimvdLippe
suggested changes
Aug 10, 2018
Fixed. Glad we're testing the types compile in CI now! |
Had to fix gestures.js too. We set |
dfreedm
requested changes
Aug 10, 2018
lib/utils/gestures.js
Outdated
| * @param {string} value Touch action value | ||
| * @return {void} | ||
| */ | ||
| export function setTouchAction(node, value) { | ||
| if (HAS_NATIVE_TA) { | ||
| if (HAS_NATIVE_TA && node instanceof Node) { |
There was a problem hiding this comment.
This should be a check for Element to ensure the style property.
There was a problem hiding this comment.
Done (HTMLElement actually)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows passing e.g.
window, which I assume is valid here?