Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[legacy-data-mixin 2.x] Ensure wildcard arguments get undefined treatment. Fixes #5428 #5523

Merged
merged 1 commit into from
Apr 13, 2019

Conversation

kevinpschaaf
Copy link
Member

When checking the results of _marshalArgs for undefined values, a wildcard argument would normally always have an object and thus would not trigger a warning even if the underlying base object was undefined. In those cases check wildcard argument's base object for undefined, which would match Polymer 1's undefined rule behavior.

Reference Issue

Fixes #5428.

@kevinpschaaf kevinpschaaf changed the base branch from master to 2.x April 12, 2019 00:31
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@kevinpschaaf
Copy link
Member Author

LGTM from sorvell based on #5522 review.

@kevinpschaaf kevinpschaaf merged commit 8d4a459 into 2.x Apr 13, 2019
@kevinpschaaf kevinpschaaf deleted the 5428-kschaaf-undefined-wildcard-2.x branch April 13, 2019 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants