Add module field #5594
Merged
Add module field #5594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://unpkg.com/@polymer/polymer@3.3.0?module fails to load saying that the package is not an ES module. Adding `module` field should allow it to load (see: https://github.com/mjackson/unpkg/blob/4bb6cf424a6f7e803fc98c13662ee4d04bfe4af2/modules/middleware/validateFilename.js#L7)
rslawik
requested review from
dfreedm,
kevinpschaaf,
sorvell and
TimvdLippe
as code owners
justinfagnani
suggested changes
Oct 7, 2019
|
@azakus @kevinpschaaf how do we maintain the CHANGELOG in Polymer? Is it generated or updated by hand? |
|
Yeah, the changelog in the polymer repro predates when we made changelogs per PR; we run a script at release time to gather the commit log. |
|
If the changelog is updated automatically, can we merge this PR in? |
|
Ping. It seems that the CHANGELOG update is not a blocker to merge this. Once merged, when is it expected to be published to npm? |
kevinpschaaf
approved these changes
Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://unpkg.com/@polymer/polymer@3.3.0?module fails to load saying that the package is not an ES module. Adding
modulefield should allow it to load (see: https://github.com/mjackson/unpkg/blob/4bb6cf424a6f7e803fc98c13662ee4d04bfe4af2/modules/middleware/validateFilename.js#L7)