Add differentiated project templates #2
Conversation
This reverts commit 91a6e00.
There was a problem hiding this comment.
Looks good to my initial review. We should be able to publish this as @polymer/tools-sample-projects, add a dev dependency on it in CLI and run over these scenarios in the CLI's integration tests.
We still might want to do a manual test to ensure that everything looks right (the styles are correct, etc), but it would go a long way.
| @@ -1,6 +1,6 @@ | |||
| <!-- | |||
| @license | |||
| Copyright (c) 2016 The Polymer Project Authors. All rights reserved. | |||
| Copyright (c) 2017 The Polymer Project Authors. All rights reserved. | |||
There was a problem hiding this comment.
Here and elsewhere: general guidance is not to update copyright date for existing files. If these files were actually created in 2017 then this is just a correction and probably fine.
There was a problem hiding this comment.
These are corrections in polymer-1-app and new additions in polymer-2-app. This repo was started in 2017 but this was done for completeness more than anything. Happy to back out if we prefer to leave it as is.
polymer-1-app/src/my-app.html
Outdated
| @@ -22,7 +22,7 @@ | |||
| <link rel="import" href="../bower_components/paper-icon-button/paper-icon-button.html"> | |||
| <link rel="import" href="my-icons.html"> | |||
|
|
|||
| <dom-module id="my-app"> | |||
| <dom-module name="my-app"> | |||
| <template> | |||
| <style> | |||
There was a problem hiding this comment.
<style> can be outside <template> (but still inside dom-module) for 1.0 elements, if you're looking to do idiosyncratic 1.0 things
There was a problem hiding this comment.
I added name-view already as an example of name vs. id and some other patterns like <style> outside of <template>. I'll leave them there to represent 1.0 things and back out this change since it is no longer strictly needed.
There was a problem hiding this comment.
@rictic that's been deprecated since 1.1 though.
polymer-2-app/README.md
Outdated
| @@ -0,0 +1,97 @@ | |||
| # Polymer App Toolbox - Starter Kit | |||
There was a problem hiding this comment.
Does this readme apply here? Recommend dropping or updating it.
|
Looks good, but I think there's a lot of things that could be trimmed to leave the more salient bits. Let's just get this in now though. |
| @@ -126,12 +130,12 @@ | |||
|
|
|||
| _pageChanged: function(page) { | |||
| // Load page import on demand. Show 404 page if fails | |||
| var resolvedPageUrl = this.resolveUrl('my-' + page + '.html'); | |||
| var resolvedPageUrl = this.resolveUrl('views/' + page + '.html'); | |||
There was a problem hiding this comment.
we should use lazy imports in one of the 1.0 scenarios
| If deploying in a folder replace href="/" with the full path to your site. | ||
| Such as: href=="http://polymerelements.github.io/polymer-starter-kit" | ||
| --> | ||
| Oops you hit a 404. <a href="/">Head back to home.</a> | ||
| <div class="card"> | ||
| Oops you hit a 404. <a href="/">Head back to home.</a> |
There was a problem hiding this comment.
what's this view testing?
| <link rel="import" href="../../bower_components/polymer/polymer.html"> | ||
| <link rel="import" href="../shared-styles.html"> | ||
|
|
||
| <!-- element template --> |
There was a problem hiding this comment.
you can remove these comments
| <div> | ||
| <content></content> | ||
| <br /> | ||
| <div>There are <strong>[[name]]</strong> childNode elements total.</div> |
There was a problem hiding this comment.
what's this element testing?
| } | ||
| </style> | ||
|
|
||
| <!-- | ||
| <!-- |
There was a problem hiding this comment.
can remove this. In general I'd remove a lot of PSK guidance comments and they're probably noise in the way of us seeing what's relevant.
| } | ||
| </script> | ||
|
|
||
| <script src="/bower_components/webcomponentsjs/webcomponents-lite.js"></script> |
There was a problem hiding this comment.
use webcomponents-loader.js
| } | ||
| } | ||
|
|
||
| window.customElements.define(MyApp.is, MyApp); |
There was a problem hiding this comment.
ooh, interesting, we need to account for not having a string literal
|
@justinfagnani agreed, there's still some PSK-related stuff in the templates. This is nice because it gives us a way to serve and navigate between the views to make sure they're all displaying properly, but it does mean there's more than we need from a tooling perspective. |
polymer-1-appto use differentiated, polymer v1-specific patternspolymer-2-appwith differentiated, polymer v2-specific patternspolymer-1-hybrid-appandpolymer-2-hybrid-appwhich will be simple combinations of these two projects. (Future PR)It was too difficult to coordinate changes across two different PRs, so my work on both projects is here. But they are separated by commit, if you'd prefer to review that way.
/cc @justinfagnani @rictic @usergenic