Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Name mangling mismangles names when emitting ES6 #261

Closed
rictic opened this issue Apr 27, 2018 · 3 comments
Closed

[build] Name mangling mismangles names when emitting ES6 #261

rictic opened this issue Apr 27, 2018 · 3 comments
Labels

Comments

@rictic
Copy link
Contributor

rictic commented Apr 27, 2018

When testing shop's 3.0 branch, looking at the esm-bundled and es6-bundled outputs, we've got a function like:

function foo(bar, baz) {
  for (let i = 0; i < zim; i++) {
    zoop(bar, baz);
  }
}

and after minification we end up with:

function foo(h, i) {
  for (let i = 0; i < z; i++) {
    zoop(h, i);
  }
}

The param names clashes with the loop index after renaming, so instead of an array we see a number.

@rictic
Copy link
Contributor Author

rictic commented Apr 27, 2018

I'm temporarily turning off name mangling while I get a tighter repro of this issue.

rictic added a commit that referenced this issue Apr 27, 2018
rictic added a commit that referenced this issue Apr 27, 2018
rictic added a commit that referenced this issue Apr 27, 2018
rictic added a commit to Polymer/shop that referenced this issue Apr 27, 2018
@stale
Copy link

stale bot commented Mar 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented Apr 21, 2022

This issue has been automatically closed after being marked stale. If you're still facing this problem with the above solution, please comment and we'll reopen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant