Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hoist typescript and tslint to top-level package.json #399

Merged
merged 5 commits into from
May 18, 2018
Merged

Hoist typescript and tslint to top-level package.json #399

merged 5 commits into from
May 18, 2018

Conversation

justinfagnani
Copy link
Contributor

No description provided.

@justinfagnani justinfagnani requested a review from rictic May 17, 2018 23:25
@justinfagnani
Copy link
Contributor Author

Updated the package-locks with npm nuke which shaved 600MB off the total install size after hoisting.

rictic
rictic approved these changes May 18, 2018
View reviewed changes
Copy link
Contributor

@rictic rictic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, 600MB saved, that's like, 50%?

@justinfagnani
Copy link
Contributor Author

@rictic seemed like ~33% to me :/

@justinfagnani justinfagnani merged commit 219ab4f into master May 18, 2018
@justinfagnani justinfagnani deleted the hoist branch May 18, 2018 18:35
@snyk-bot snyk-bot mentioned this pull request Mar 7, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Sep 17, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Jun 19, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rictic rictic rictic approved these changes

@TimvdLippe TimvdLippe TimvdLippe approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@justinfagnani @rictic @TimvdLippe @googlebot