Added lint to packages missing it and made linting a final build step. #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is also being done in #677 ? |
rictic
reviewed
Oct 5, 2018
packages/workspaces/tslint.json
Outdated
| @@ -1,60 +1,61 @@ | |||
| { | |||
There was a problem hiding this comment.
It looks like this has both /tslint.json and /packages/workspaces/tslint.json?
There was a problem hiding this comment.
Resolved: workspaces/tslint.json is now just extending /tslint.json
|
@TimvdLippe oh my -- you're right. Reviewing #677 right now. |
|
Merged #677 and resolved conflicts in this branch. |
Fixed: I had moved lines in JSON object but didn't maintain comma integrity!
…nalyzer build not include depcheck which is expensive.
43081j
reviewed
Oct 6, 2018
aomarks
approved these changes
Oct 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
curly: trueand fixed code where lint reported typings were too vague.