Clean up app-header CSS #103
Conversation
| transition: opacity 0.4s; | ||
| -webkit-transform: translateZ(0); |
There was a problem hiding this comment.
Did you find any perf/rendering implication in Safari 8, 9 and iOS? I remember seeing a few issues that went away after adding this rule -webkit-transform: translateZ(0);. In one of them, the shadow didn't render properly and it looked like a solid black box (clearly a bug in Safari). In the second issue, I noticed that sometimes the shadow rendered underneath the content because we don't use z-index, so adding translateZ(0) I believe fixed the issue. It would be good to try with a fixed header that doesn't condense, but that has the waterfall effect to see if we can still repro the issue.
There was a problem hiding this comment.
I tested the app-header demos on Safari 8 (my Yosemite VM) and the iOS 9 simulator - I didn't see any visual changes on them
keanulee
changed the title
keanulee
changed the title
|
LGTM |
The commit where these styles were added: ce71a6a
cc @frankiefu @blasten