A11y shrine: missing alts attributes #361
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blasten
suggested changes
Nov 3, 2016
| @@ -4,8 +4,10 @@ | |||
| "title": "Green comfort chair", | |||
| "quote": "Leave the tunnel and the rain is fallin amazing things happen when you wait", | |||
| "imageUrl": "https://www.gstatic.com/angular/material-adaptive/shrine/chair.png", | |||
| "imageAlt": "foobar", | |||
There was a problem hiding this comment.
We could just use title as the alt text for imageUrl.
There was a problem hiding this comment.
I know but I would like to show it with different values. Because if you don´t do that (my opinion), maybe people missunderstand what should be the correct value of an alt attribute (the context is important) and they think that it allways is valid with a title value you write in the page.
| "storeName": "Ali’s shop", | ||
| "storeAvatarUrl": "https://www.gstatic.com/angular/material-adaptive/shrine/ali-connors.png", | ||
| "storeAvatarAlt": "foobar", |
There was a problem hiding this comment.
Similarly, we could just use storeName as the alt text for storeAvatarUrl.
|
Closing this PR, for now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #356.