Automatic format! #545
Automatic format! #545
Conversation
| Polymer.AppScrollEffectsBehavior, | ||
| Polymer.IronResizableBehavior | ||
| ], | ||
| behaviors: [Polymer.AppScrollEffectsBehavior, Polymer.IronResizableBehavior], |
There was a problem hiding this comment.
At what point does the formatter decide to have each item on its own line (behaviors, listeners, and properties)? This seems like it should be.
There was a problem hiding this comment.
It's using google styleguide, so I think it's after it hits 80 cols
app-drawer/app-drawer.d.ts
Outdated
|
|
||
| interface HTMLElementTagNameMap { | ||
| "app-drawer": AppDrawerElement; | ||
| } |
There was a problem hiding this comment.
The typings for app-drawer are now missing
There was a problem hiding this comment.
that. is. not. supposed. to. happen. 😕
There was a problem hiding this comment.
ah this is because the missing semicolons caused a typescript syntax error
app-drawer/app-drawer.html
Outdated
| @@ -283,8 +255,9 @@ | |||
| this._boundEscKeydownHandler = this._escKeydownHandler.bind(this); | |||
| this.addEventListener('keydown', this._tabKeydownHandler.bind(this)) | |||
|
|
|||
| // Only listen for horizontal track so you can vertically scroll inside the drawer. | |||
| this.listen(this, 'track', '_track'); | |||
| // Only listen for horizontal track so you can vertically scroll | |||
There was a problem hiding this comment.
Missing semicolon above is causing this indentation.
app-drawer/app-drawer.html
Outdated
| var t = this._FLING_INITIAL_SLOPE * dx / velocity | ||
| this._styleTransitionDuration(t); | ||
| var t = this._FLING_INITIAL_SLOPE * dx / | ||
| velocity this._styleTransitionDuration(t); |
| * whereas the rest of the elements will collapse below `sticky` element. | ||
| * That is, the `sticky` element remains visible when the header is fully | ||
| *condensed whereas the rest of the elements will collapse below `sticky` | ||
| *element. |
There was a problem hiding this comment.
nit: no space between * and text. Not a blocker, but curious why linter doesn't handle this.
There was a problem hiding this comment.
odd.. it should clang-format does not
| * | ||
| * ```html | ||
| * <link rel="import" href="/bower_components/app-layout/app-scroll-effects/app-scroll-effects.html"> | ||
| * <link rel="import" | ||
| * href="/bower_components/app-layout/app-scroll-effects/app-scroll-effects.html"> |
There was a problem hiding this comment.
This might be an issue with the README generator (i.e. will it remove the * in the HTML block), but maybe it's ok?
There was a problem hiding this comment.
I can tell it to not reflow comments do you think that's best? Otherwise clang-format does not support adding the space before
There was a problem hiding this comment.
Sheesh, nevermind, that's a bad bad flag
There was a problem hiding this comment.
I think it's better if it enforces the line limits on all comments - code snippets in comments are a small use case, and I'm not even sure if the README generator is used on this repo anyways. Suggest you ignore this issue for now, and we'll deal with it if it's an issue later.
There was a problem hiding this comment.
I'll make an issue in webmat, but I think this is an issue in the clang-format blackbox
|
fixes applied |
|
I was testing you |
|
LGTM |
Runs the experimental autoformatter webmat which runs clang-format on js files and makes it so that it can run on HTML files. Please look through this PR with
?w=1in the diff to make sure that no logic was changed.What has changed?
You can run the formatter on the whole project by running
npm run formatand ex/include files from the formatter, and enter your custom clang-format config in a formatconfig.json see webmat readme for more