Implement app-media-image-capture. #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdata
force-pushed
the
implemenet-image-capture
branch
3 times, most recently
from
ba13f51
to
46ca0fc
Compare
cdata
force-pushed
the
initial-implementation
branch
from
30703ba
to
54d96e4
Compare
cdata
force-pushed
the
implemenet-image-capture
branch
from
46ca0fc
to
f592006
Compare
townsendmerino
approved these changes
Apr 19, 2017
notwaldorf
approved these changes
Apr 19, 2017
| value: null | ||
| }, | ||
|
|
||
| /** @see https://www.w3.org/TR/image-capture/#PhotoSettings */ |
There was a problem hiding this comment.
i see we gave up on a blorb describing these props that isn't this generic link? If you're not too lazy, i'd still add like one sentence about what it is
|
|
||
| - ✅ Stable native implementation | ||
| - 🚧 Partial fidelity with polyfill | ||
| - 🚫 Not supported at all |
There was a problem hiding this comment.
(just cheering for emoji not content)
| "iron-resizable-behavior": "PolymerElements/iron-resizable-behavior#1.0.0 - 2" | ||
| }, | ||
| "devDependencies": { | ||
| "iron-component-page": "PolymerElements/iron-component-page#1.0.0 - 2", | ||
| "web-component-tester": "Polymer/web-component-tester#^6.0.0-prerelease.6", | ||
| "webcomponentsjs": "webcomponents/webcomponentsjs#0.7.0 - 1", | ||
| "test-fixture": "PolymerElements/test-fixture#1.0.0 - 3", | ||
| "imagecapture-polyfill": "https://unpkg.com/image-capture@0.3.2/lib/imagecapture.js", |
| : {}; | ||
| return function FakeImageCapture(videoTrack) { | ||
| return { | ||
| $videoTrack: videoTrack, |
There was a problem hiding this comment.
I don't know. It means don't touch me? This is a property that doesn't exist on an actual video track. I can take it out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.