Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix polymer 2 bug in app-media-image-capture #60

Closed
wants to merge 1 commit into from
Closed

Fix polymer 2 bug in app-media-image-capture #60

wants to merge 1 commit into from

Conversation

j0000el
Copy link
Contributor

@j0000el j0000el commented Oct 3, 2018

In polymer 2, observed properties can be undefined, so properly handle those cases. Fixes bug where "Failed to construct 'ImageCapture'" exception is thrown causing subsequent calls to takePhoto() to fail.

Fixes #59

In polymer 2, observed properties can be undefined, so properly handle those cases. Fixes bug where "Failed to construct 'ImageCapture'" exception is thrown causing subsequent calls to takePhoto() to fail.
@j0000el j0000el requested a review from e111077 as a code owner October 3, 2018 23:04
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@e111077
Copy link
Member

e111077 commented Oct 3, 2018

Nice, please resolve the CLA issue and this PR is good to go!

@e111077
Copy link
Member

e111077 commented Oct 4, 2018

Closing. Please reopen when CLA issue is resolved. Thanks!

@e111077 e111077 closed this Oct 4, 2018
@j0000el
Copy link
Contributor Author

j0000el commented Oct 5, 2018

I signed it!

@e111077 e111077 reopened this Oct 5, 2018
@e111077
Copy link
Member

e111077 commented Oct 5, 2018

Can you try to kick it one more time? If not, I'd check your commit history to see if it was authored with the correct email address.

@j0000el
Copy link
Contributor Author

j0000el commented Oct 9, 2018

Created #61 with the correct email address.

@j0000el j0000el closed this Oct 9, 2018
@j0000el j0000el deleted the patch-1 branch October 9, 2018 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants