-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Add screen capture use case #8
Docs: Add screen capture use case #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing these docs. Can you please also add a back-reference to the Paul Kinlan article about this (or a better reference, if you have one).
README.md
Outdated
@@ -109,6 +109,36 @@ something like this: | |||
</app-media-stream> | |||
``` | |||
|
|||
You can use `app-media-stream` to record device screen. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to record device screen => to record a device screen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
README.md
Outdated
@@ -109,6 +109,36 @@ something like this: | |||
</app-media-stream> | |||
``` | |||
|
|||
You can use `app-media-stream` to record device screen. | |||
|
|||
To capture screen in Chrome use `{"mandatory": {"chromeMediaSource": "screen"}}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To capture screen => To capture the screen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
@FluorescentHallucinogen thanks for the changes. Please also refer to my request in this comment. |
I don't mind to add it, but what's it for? Looks like, unfortunately, as of today there is no single up to date source about extensionless (plugin-free) screen capturing in both, Chrome and Firefox browsers. E.g. @PaulKinlan's https://paul.kinlan.me/screen-recording-with-getUserMedia-and-WebRTC/ article has no word about Firefox. Seems, the https://www.webrtc-experiment.com/Pluginfree-Screen-Sharing/#why-screen-fails section of @muaz-khan's page and his explanations in the comments are most relevant reference. |
@cdata Where exactly in the text should I add the reference? This pull request allows edits from maintainers. Could you please help me and add it yourself. |
It will be sufficient to add a note to the bottom of the explanation linking to the articles you just mentioned. I appreciate your feedback. I do not have time to modify your PR for you. Please address the feedback, or else wait patiently until we have time to fix it ourselves. |
Done. |
Thanks for the contribution! |
This pull request allows edits from maintainers. English is not my native language. Feel free to correct mistakes in the text, if there are any. 😉