Inheritance #16
Closed
Inheritance #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -62,7 +62,36 @@ | |||
| // TODO: disallow name clashes in match. Allow regex? | |||
|
|
|||
| __tryToMatch: function(path, match) { | |||
| if (this._skipMatch || !path || !match) { | |||
| debugger; | |||
| if (matchResult == null) { | ||
| this._matched = null; | ||
| // this.tail = null; | ||
| // this.data = ???; |
There was a problem hiding this comment.
If these are related to something meaningful, can we leave a TODO?
| return; | ||
| } | ||
|
|
||
| var matchResult = this.matchPath(path, match); |
There was a problem hiding this comment.
Is there an explicit signature for matchPath? Is it okay if sometimes it returns null vs undefined?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15
Shouldn't be merged until the
extendsbranch lands in Polymer, and without changes to revert thebower.jsonchange in this PR.