Implement <carbon-location>
#4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdata
force-pushed
the
implement-carbon-location
branch
from
970432d
to
79a37f6
Compare
|
Advanced apologies for not properly |
cdata
force-pushed
the
implement-carbon-location
branch
from
79a37f6
to
65d5739
Compare
| queryParams: { | ||
| type: Object, | ||
| value: function() {return {};}, | ||
| notify: true, | ||
| }, | ||
|
|
||
| /** | ||
| * The serialized path through the route tree. |
There was a problem hiding this comment.
The serialized/deserialized path through the route tree is accurate but maybe not super helpful without some more verbiage that grounds it in terms that users are more familiar with. I think it's also worth pointing out that route is intended to be handed to carbon-route objects.
cdata
force-pushed
the
implement-carbon-location
branch
from
65d5739
to
96b71f7
Compare
|
|
||
| test('it reflects queryParams values to location.search', function() { | ||
| carbonLocation.set('route.queryParams.foo', 1); | ||
| expect(window.location.search).to.match(/foo=1/); |
|
LGTM! One optional comment |
- `<carbon-router>` has been re-imagined as the more obscure, more unwieldy `<carbon-route-converter>` aka "do not use unless you know what you are doing." - `<carbon-location>` is a macro element that composes `<iron-page-url>`, `<iron-query-params>` and `<carbon-route-converter>`
cdata
force-pushed
the
implement-carbon-location
branch
from
96b71f7
to
6d25d9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<carbon-router>has been re-imagined as the more obscure, moreunwieldy
<carbon-route-converter>aka "do not use unless you knowwhat you are doing."
<carbon-location>is a macro element that composes<iron-page-url>,<iron-query-params>and<carbon-route-converter>