guard against null keyEventTarget #48
Conversation
There are two calls to _listenKeyEventListeners() and one already guards against null this.keyEventTarget. This change guards the call to _listenKeyEventListeners in attached from using a null keyEventTarget.
|
/cc @valdrinkoshi, @dbeam |
|
It may be worth moving the keyEventTarget check into _listenKeyEventListeners() rather than checking keyEventTarget before calling _listenKeyEventListeners(). WDYT? |
Moving the keyEventTarget check into _listenKeyEventListeners()
| this._listenKeyEventListeners(); | ||
| } | ||
| }, | ||
|
|
||
| _listenKeyEventListeners: function() { | ||
| if (!this.keyEventTarget) { |
There was a problem hiding this comment.
That's a much better place for this check! 🍻
|
Thanks for the contribution @dschuyler! |
|
Fixes #49 |
| var element = document.createElement('x-a11y-basic-keys'); | ||
| element.keyEventTarget = null; | ||
| Polymer.dom(container).appendChild(element); | ||
| done(); |
There was a problem hiding this comment.
Nit: since the test is synchronous, you don't need to have to call the done callback (remove it from here and from line 444)
|
LGTM, thanks for your contribution @dschuyler! |
There are two calls to _listenKeyEventListeners() and one already guards against null this.keyEventTarget. This change guards the call to _listenKeyEventListeners in attached from using a null keyEventTarget.