Make demo more appealing #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blasten
force-pushed
the
demo
branch
3 times, most recently
from
b4e17c2
to
6537036
Compare
| </style> | ||
| <template> | ||
| <span>Press any of these keys: <span>[[boundKeys]]</span></span> | ||
| <pre id="output">[[pressed]]</pre> | ||
| <p class="keys">Press any of these keys: |
There was a problem hiding this comment.
I think it would be nicer/consistent with all the other demos if this content lived in the white-background-with-shadow-card-looking thing. There's styles for this in paper-styles/demo-pages. So if you look, for example, at the iron-autogrow-textarea, this should be
<div class="vertical-section-container centered">
<h4>Press any of these keys</h4>
<div class="vertical-section">
<template is="dom-repeat" items="..".>
...
</template>
</div>
</div>
| "iron-component-page": "polymerelements/iron-component-page#^1.0.0", | ||
| "iron-test-helpers": "polymerelements/iron-test-helpers#^1.0.0", | ||
| "test-fixture": "polymerelements/test-fixture#^1.0.0", | ||
| "web-component-tester": "*", | ||
| "webcomponentsjs": "webcomponents/webcomponentsjs#^0.7.0" | ||
| }, | ||
| "resolutions": { |
There was a problem hiding this comment.
no resolutions should be needed
|
lgtm % comment (there's resolutions leftover in bower.json) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @notwaldorf
