Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added aria label to element #97

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kalaspuffar
Copy link

@kalaspuffar kalaspuffar commented Feb 23, 2017

Fixes #98

Added aria label to the element so it is in the same shadow DOM and read by screen readers.

I wondered why I wasn't able to get the screen reader to read the label of my input-textarea and it seems to be because of encapsulation between components.

Tested on Chrome with NVDA screen reader.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@kalaspuffar
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants