Add TypeScript declarations to iron-collapse. #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valdrinkoshi
reviewed
Feb 2, 2018
iron-collapse.d.ts
Outdated
| */ | ||
| noAnimation: boolean|null|undefined; | ||
| hostAttributes: object|null; | ||
| dimension: object|null; |
There was a problem hiding this comment.
Dimension it's read-only (only getter available), and it can be only a string - not sure how this got interpreted as object|null - I'd have guessed it would have been interpreted as any
https://github.com/PolymerElements/iron-collapse/blob/master/iron-collapse.html#L155
There was a problem hiding this comment.
I think probably Analyzer does not understand getters on elements. Will need to investigate.
There was a problem hiding this comment.
This is now fixed, see latest commit.
aomarks
force-pushed
the
gen-typescript-declarations
branch
from
762845c
to
5250b67
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds TypeScript declarations generated by https://github.com/Polymer/gen-typescript-declarations/
These declarations can be re-generated by running
npm run update-types.Tracker: https://github.com/Polymer/gen-typescript-declarations/issues/79