Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply .layout will be horizontal(row) by default. #94

Merged
merged 1 commit into from
Apr 17, 2017
Merged

apply .layout will be horizontal(row) by default. #94

merged 1 commit into from
Apr 17, 2017

Conversation

herobs
Copy link
Contributor

@herobs herobs commented May 24, 2016

No description provided.

apply `.layout` will be horizontal(row) by default.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@herobs
Copy link
Contributor Author

herobs commented May 24, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@herobs
Copy link
Contributor Author

herobs commented Jun 3, 2016

Close #93

@notwaldorf notwaldorf merged commit 8dc3339 into PolymerElements:master Apr 17, 2017
@z2oh
Copy link

z2oh commented Apr 19, 2017

Are CSS class changes considered breaking changes? Our deploy process pulled this latest release (we had ^1.0.0 tagged in our bower.json) and we spent a good while figuring out what caused our UI to break. All we needed to do was add the vertical class to all our divs that previously just had the layout class on them, but it took a while to narrow down exactly what was causing the issue.

@notwaldorf
Copy link
Contributor

Oh hmmm they're definitely considered breaking changes. I didn't realize you could be using layout without "horizontal" or "vertical" -- sorry about that. Will send a fix today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants