demonstrate reacting to form's submitted state changes #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@azakus Looks like this Travis build failed for unrelated reasons. Could you force trigger a new build for this PR once the build is fixed? |
|
@jab, you need to rebase with master branch to get the travis config. |
jab
force-pushed
the
demo-submit-loading
branch
from
3580f65
to
f629d6f
Compare
|
Thanks @azakus, the build is passing now. |
| @@ -21,7 +21,8 @@ | |||
| "ignore": [], | |||
| "dependencies": { | |||
| "polymer": "Polymer/polymer#^1.0.0", | |||
| "iron-ajax": "PolymerElements/iron-ajax#^1.0.0" | |||
| "iron-ajax": "PolymerElements/iron-ajax#^1.0.0", | |||
| "paper-spinner": "PolymerElements/paper-spinner#~1.0.3" | |||
There was a problem hiding this comment.
This is a dev dependency, since it's used in the demo and not the element itself :)
|
Closing, since this is an old PR and it has unaddressed comments. Please re-open when it's ready for another review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass at #68