Use the non-element API for iron-meta #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The element API is just a wrapper around the non-element API. This is cleaner, simpler, and fixes an odd bug in FireFox where the iron-icon has been upgraded but its _meta property has not been.
|
How does this fare internally and can you confirm tests work on Safari 10? |
|
Rerunning Safari tests pass, as do all internal tests |
e111077
approved these changes
Feb 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The element API is just a wrapper around the non-element API.
This is cleaner, simpler, and fixes an odd bug in FireFox where the
iron-icon has been upgraded but its _meta property has not been.
Downstreamed as cl/232029631