3.0 updates #88
3.0 updates #88
Conversation
README.md
Outdated
| Using svg elements to create icons has a few advantages over traditional bitmap | ||
| graphics like jpg or png. Icons that use svg are vector based so they are | ||
| resolution independent and should look good on any device. They are stylable | ||
| via css. Icons can be themed, colorized, and even animated. | ||
|
|
||
| Example: |
There was a problem hiding this comment.
These are just copy pasted from the element docs, no? I think we're just linking to them, and deleting everything else, as per https://raw.githubusercontent.com/PolymerElements/paper-input/85c6cfd45ba0f0c6c76bceee93b5f18890e2c655/README.md
There was a problem hiding this comment.
SGTM; I replaced this top section with the links in the example there.
demo/index.html
Outdated
|
|
||
| document.body.appendChild($_documentContainer.content); | ||
| </script> | ||
| const $_documentContainer = document.createElement('template'); |
There was a problem hiding this comment.
we're using the html function for this now:
import {html} from '@polymer/polymer/lib/utils/html-tag.js';
const template = html``;
document.body.appendChild(template.content);
demo/svg-sample-icons.js
Outdated
| const $_documentContainer = document.createElement('template'); | ||
| $_documentContainer.setAttribute('style', 'display: none;'); | ||
|
|
||
| $_documentContainer.innerHTML = `<iron-iconset-svg name="svg-sample-icons" size="100"> | ||
| $_documentContainer.innerHTML = | ||
| `<iron-iconset-svg name="svg-sample-icons" size="100"> |
There was a problem hiding this comment.
This was the one you were mentioning offline that probably shouldn't use html, right? (left unchanged)
There was a problem hiding this comment.
Or, maybe you were talking about this comment instead?
There was a problem hiding this comment.
Changed this one to use html.
No description provided.