Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronous tests; rewrote detach basic test #15

Merged
merged 2 commits into from
Feb 12, 2016
Merged

Synchronous tests; rewrote detach basic test #15

merged 2 commits into from
Feb 12, 2016

Conversation

e111077
Copy link
Member

@e111077 e111077 commented Feb 12, 2016

Fixes #12

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot
Copy link

CLAs look good, thanks!

@@ -114,44 +105,28 @@
ListenForResize(testEl.$.shadow1c.$.resizable),
ListenForResize(testEl.$.shadow1d.$.resizable)
];

setTimeout(function() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍻

@cdata
Copy link
Contributor

cdata commented Feb 12, 2016

LGTM 👍

e111077 added a commit that referenced this pull request Feb 12, 2016
Synchronous tests; rewrote detach basic test
@e111077 e111077 merged commit f0d5511 into master Feb 12, 2016
@e111077 e111077 deleted the fixMSEdge branch February 12, 2016 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants