Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a singleton IronMeta instance instead of creating one for each element.
I've done a global search, and
validatorType
was never used. Also, it didn't have an observer and was only used inready
, so it's unlikely it ever worked correctly (I think it was intended to be a config time property, before we knew how to document private properties). Similarly for the_validatorMeta
(which already looked private-y). I've added notes to them not to be used.I've also cached the
_validator
in a computed property, rather than a getter, since the getter gets called invalidate()
, which could be on every key stroke (for auto-validating inputs). I added a unit test for this.Performance improvement:
![screen shot 2016-04-21 at 5 33 00 pm](https://cloud.githubusercontent.com/assets/1369170/14728687/e97fbe2a-07eb-11e6-959f-382c7291d8d8.png)
I ran
tattoo
on this branch, and these are the results. Both failures are unrelated to this PR: