You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've also tried installing the neon-animation package with bower. It doesn't have this issue because when installed with bower, it ends up in bower_components/neon-animation so it is in fact a sibling. So this is a possible workaround (not for me in particular, I'd like to stick to npm), but it would be sweet to get this to work out of the box with npm as well. I can imagine that the polyfill failing to load may cause grief to people trying to use this.
To reproduce, put this as package.json into an empty directory: { "name": "foo", "version": "0.1.0", "engines": { "node": "^4.0.0" }, "dependencies": { "@polymer/neon-animation": "0.0.3", "web-animations-js": "2.2.1" } }
Run npm install there and observe that the link contained in node_modules/@polymer/neon-animation/web-animations.html points at a sibling directory.
I'm using Polymer with npm. So, to get the neon-animation package, I added this to the dependencies in my package.json:
"@polymer/neon-animation": "0.0.3",
Upon running npm install, this will pull in the neon-animation package, as
node_modules/@polymer/neon-animation
.But we also need web-animations-next-lite.min.js, so I added this other dependency as well:
"web-animations-js": "2.2.1",
This gets installed in
node_modules/web-animations
.Now the problem is that in this file ...
https://github.com/PolymerElements/neon-animation/blob/master/web-animations.html
... there is a relative link, and it points at a sibling directory
web-animations
, but it's not in fact a sibling becauseneon-animation
is underneath@polymer
, so we'd need../../
instead of../
.I've also tried installing the neon-animation package with
bower
. It doesn't have this issue because when installed with bower, it ends up inbower_components/neon-animation
so it is in fact a sibling. So this is a possible workaround (not for me in particular, I'd like to stick tonpm
), but it would be sweet to get this to work out of the box withnpm
as well. I can imagine that the polyfill failing to load may cause grief to people trying to use this.To reproduce, put this as
package.json
into an empty directory:{ "name": "foo", "version": "0.1.0", "engines": { "node": "^4.0.0" }, "dependencies": { "@polymer/neon-animation": "0.0.3", "web-animations-js": "2.2.1" } }
Run
npm install
there and observe that the link contained innode_modules/@polymer/neon-animation/web-animations.html
points at a sibling directory./cc: @morethanreal
The text was updated successfully, but these errors were encountered: