Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation persistence #70

Closed

Conversation

jorgecasar
Copy link

This implements animations persistence. It's very useful for pairs animations such as fade-in/fade-out, because you don't have to manage the final state based on a local variable to know what's the state of the component. And you can avoid the use of a listener to wait for the animation finished.

@addyosmani
Copy link
Contributor

Thanks for your patch to the project, @jorgecasar. After reviewing your suggestions for animation persistence, I'm of the opinion that we're not quite ready for this in master. The listener approach for waiting on the animation to end has served us well so far. We haven't had demand for supporting this type of feature (yet) so we're going to skip this PR for now. If folks get back to us about wanting this in at some point we'll consider reopening this PR.

Cheers once again for trying to help!

@addyosmani addyosmani closed this Jan 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants