Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃崟 Add checkbox size var #60

Closed

Conversation

samccone
Copy link

@samccone samccone commented Sep 3, 2015

Fixes #59


screen shot 2015-09-02 at 4 59 22 pm

@notwaldorf
Copy link
Contributor

@samccone I think the ripple is the wrong size though :(

@samccone
Copy link
Author

samccone commented Sep 3, 2015

oh shucks 馃槩

@samccone
Copy link
Author

samccone commented Sep 3, 2015

word word @notwaldorf so the ripple centering was simple enough... however I have run into an interesting issue with a var( inside of a calc .. inside of a @keyframes def ... it looks like it is not being translated at all.. which makes moving the check box to the center difficult (see impossible) since the position of the checkbox is being set "finally" via the animation. 馃幉

This seems to be a limitation around the css var shim that we have in place 馃悙

Any thoughts on this?

@notwaldorf
Copy link
Contributor

Gonna throw @sorvell at this one and see what he says 馃巿

@sorvell
Copy link
Contributor

sorvell commented Sep 3, 2015

Polymer's custom properties cannot currently be consume in @Keyframe rules. Filed Polymer/polymer#2399 to track progress on fixing this.

@notwaldorf
Copy link
Contributor

@samccone Doing some cleanup -- can I close this PR until the Polymer fix is ready, and then you can maybe re-open it/re-visit then?

@samccone
Copy link
Author

馃憤 sgtm can we xlink in the polymer issue back so we do not forget:) 馃挱

@notwaldorf
Copy link
Contributor

Done!

@notwaldorf notwaldorf closed this Oct 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants