Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove noop IIFE #286

Merged
merged 2 commits into from
Apr 3, 2018
Merged

Remove noop IIFE #286

merged 2 commits into from
Apr 3, 2018

Conversation

rictic
Copy link
Contributor

@rictic rictic commented Apr 3, 2018 •
edited
Loading

Makes things easier on closure compiler.

This externalizes a CL from @MatrixFrog. See go/polymer-upstream

valdrinkoshi
valdrinkoshi requested changes Apr 3, 2018
View reviewed changes
Copy link
Member

@valdrinkoshi valdrinkoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mind updating also paper-dropdown-menu-light and run npm run update-types?

@rictic
Copy link
Contributor Author

rictic commented Apr 3, 2018

👍

@valdrinkoshi
Copy link
Member

@rictic nvm just did it in ecc7990

@valdrinkoshi valdrinkoshi merged commit b41d88e into master Apr 3, 2018
@valdrinkoshi valdrinkoshi deleted the noop-iife branch April 3, 2018 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valdrinkoshi valdrinkoshi valdrinkoshi approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rictic @valdrinkoshi @googlebot